Buffer overflow by one byte

2012-02-29 00:30:14 +01:00 · 2012-02-29 00:30:14 +01:00 · 647e3dddea
commit 647e3dddea
parent 804773eb22
1 changed files with 1 additions and 2 deletions
--- a/bbswitch.c
+++ b/bbswitch.c
@ -74,9 +74,8 @@ int dis_before_suspend_disabled;
 static char *buffer_to_string(const char *buffer, size_t n, char *target) {
    int i;
    for (i=0; i<n; i++) {
-        sprintf(target + i * 5, "%02X,", buffer[i]);
+        snprintf(target + i * 5, 5 * (n - i), "%02X,", buffer[i]);
    }
-    target[n * 5] = '\0';
    return target;
 }