shark/bbswitch-g14
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't share buffer for muid/args, it'll be overwritten

Browse Source
This commit is contained in:
Lekensteyn
2012-02-29 00:49:34 +01:00
parent 647e3dddea
commit f034252a13
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
bbswitch.c
View File

@@ -111,12 +111,13 @@ static int acpi_call_dsm(acpi_handle handle, const char muid[16], int revid,
err = acpi_evaluate_object(handle, "_DSM", &input, &output);
if (err) {
char tmp[5 * 16]; /* enough space for muid or args with separators */
char muid_str[5 * 16];
char args_str[5 * 4];
printk(KERN_WARNING "bbswitch: failed to evaluate _DSM {%s} %X %X"
" {%s}: %s\n",
buffer_to_string(muid, 16, tmp), revid, func,
buffer_to_string(args, 4, tmp), acpi_format_exception(err));
buffer_to_string(muid, 16, muid_str), revid, func,
buffer_to_string(args, 4, args_str), acpi_format_exception(err));
return err;
}